Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18649 populate TypedQueryReference in static metamodel #9000

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Sep 21, 2024

also rename two enums since "metamodel" is a word

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18649

also rename two enums since "metamodel" is a word
@cigaly
Copy link
Contributor

cigaly commented Sep 22, 2024

@gavinking Are you sure that else if ( element instanceof TypeElement typeElement ) in org.hibernate.processor.HibernateProcessor is OK to use? This has not been supported before Java 14 and User Guide says that Hibernate 7.0 requires at least Java 11.

@gavinking
Copy link
Member Author

Hibernate 7 targets JPA 3.2, which requires Java 17.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Sep 22, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [d026887, 6fc04ee, a406596]

› This message was automatically generated.

@gavinking gavinking force-pushed the populate branch 2 times, most recently from eb896ef to f022167 Compare September 22, 2024 19:39
@@ -222,12 +224,10 @@
);
}

if ( content instanceof JaxbHbmQueryParamType ) {
final JaxbHbmQueryParamType paramTypeBinding = (JaxbHbmQueryParamType) content;
if ( content instanceof JaxbHbmQueryParamType paramTypeBinding ) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 6 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
@cigaly
Copy link
Contributor

cigaly commented Sep 23, 2024

Hibernate 7 targets JPA 3.2, which requires Java 17.

Yes,. now I see, sorry. It seems that User Guide misguided me :-)

@gavinking gavinking merged commit 975dfa1 into hibernate:main Sep 23, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants