-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - Replace nested if statements #1334
Open
TezzardzGoneWild
wants to merge
3,742
commits into
hicetnunc2000:main
Choose a base branch
from
TezzardzGoneWild:cleanup/replace-nested-if-statements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cleanup - Replace nested if statements #1334
TezzardzGoneWild
wants to merge
3,742
commits into
hicetnunc2000:main
from
TezzardzGoneWild:cleanup/replace-nested-if-statements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacked account shutdown for megachel
not sure about that one
…event-back-button-loop Bugfix - Prevent back button loop on Artist / Collector pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several sections of code received some clean up, but no functionality change:
onReady
included a nested if statement that could be expressed using a single if statementcreationsForSale
can be expressed with two one-line if statementsgetUserMetadata
is called wrote to an intermediate variable and had multiple unnecessary if statements where writingnull
orundefined
would have the same outcomethis.state.copied
has been renamed tothis.state.discordLinkCopied
for clarityLarge if / else blocks can be intimidating to new contributors, and the main goal of this PR is to reduce the barriers for new developers wanting to contribute. Reducing the complexity of these functions should help with attracting new developers and preventing unintended side effects when touching these areas