Allow redefinition of where logging goes #111
Conversation
Artnet/Receiver.h
Outdated
| protected: | ||
| void attach(S& s) | ||
| { | ||
| this->stream = &s; | ||
| } | ||
|
|
||
| #if defined(NO_GLOBAL_INSTANCES) || defined(NO_GLOBAL_SERIAL) |
There was a problem hiding this comment.
Could you let me know what these preprocessors are?
There was a problem hiding this comment.
They're the same macros that allow disabling Serialet al in the esp32 arduino core (see here).
I had assumed when I was developing this that they were standard across all arduino cores, but it seems that they are not.
Artnet/Receiver.h
Outdated
| protected: | ||
| void attach(S& s) | ||
| { | ||
| this->stream = &s; | ||
| } | ||
|
|
||
| #if defined(NO_GLOBAL_INSTANCES) || defined(NO_GLOBAL_SERIAL) | ||
| Print* log = nullptr; // No Serial -> no output |
There was a problem hiding this comment.
I think if the user doesn’t set this, the program crashes. (nullptr->print() will be called)
There was a problem hiding this comment.
Upon further research: this is actually undefined behaviour (not neccesarily a crash), which is why I didn't catch it earlier.
Solution coming soon.
With logging disabled by default via the log variable it's somewhat redundant
|
Added a subclass of Removed This way we also don't have to worry about what happens if |
Sometimes I want to log to places other than
Serial(when I have a display connected, or when my adapter is attached toSerial1for example)Also adds guards so things don't break when the user disables
Serial