Create ArtnetEtherENC.h #79

MrFrangipane · 2024-01-05T15:20:48Z

Hello

Thank you for this awesome library.

Is it possible to make possible the use of the following library ?

Allows to use https://github.com/JAndrassy/EthernetENC

For now, I modifiy files manually, it would be awesome to have this embedded in the lib, if It helps someone else

All the best,
Val

Allows to use https://github.com/JAndrassy/EthernetENC

hideakitai

Thank you for your contribution! Could you add examples and workflows for them?

MrFrangipane · 2024-01-07T15:51:40Z

Hi !

Thanks for your response !

I'll look into it :)

Val

MrFrangipane · 2024-01-08T11:01:14Z

Hi,

I tried to add what you requested :)

The wiring diagram was taken from https://github.com/Juddling/pi-pico-enc28j60 and is reportedly made by https://github.com/tobiasvogel

I'm not familiar with workflows I copied/pasted previous sections

Hope this helps,
All the best !

MrFrangipane · 2024-01-08T11:15:32Z

Also,

It's probably not the place to ask you about this (sorry), I see here than only four callbacks are allowed https://github.com/hideakitai/ArtNet#subscribing-callbacks-with-net-sub-net-and-universe-as-you-like, why is it so ?

Thank you again,
Val

hideakitai · 2024-01-08T14:07:49Z

About callbacks, the limitation has been removed, but README is not fixed…

#59

hideakitai

Commented

hideakitai · 2024-01-08T14:17:26Z

.github/workflows/build.yml

+        board:
+          - vendor: rp2040
+            arch: rp2040
+            name: rpipico
+        include:
+          - index: https://github.com/earlephilhower/arduino-pico/releases/download/global/package_rp2040_index.json
+            board:
+              vendor: rp2040


I think EtherENC is available for any platform. If so, please add “board” and “include” as same as the “build-ethernet”.

Noted, will do

hideakitai · 2024-01-08T14:20:01Z

README.md

@@ -41,6 +41,20 @@ If you have already installed this library, please follow:
 - ESP32 (Ethernet and ETH)
 - ESP8266
 - Almost all platforms without WiFi
+- Raspberry Pi Pico with ENC28J60 (please read following section)


All platforms that can use EtherENC can be supported, I think.

You're right,

I'll check the library documentation

MrFrangipane · 2024-01-08T14:50:48Z

About callbacks, the limitation has been removed, but README is not fixed…

#59

Oh OK i was surprised to see it working, do you want me to remove this section from the readme as well ?

hideakitai · 2024-01-08T21:07:07Z

Oh OK i was surprised to see it working, do you want me to remove this section from the readme as well ?

It’s great if you can! Thank you!

MrFrangipane · 2024-01-08T22:23:15Z

I see some builds have failed

Should we remove those boards from the build and list supported boards in the docs ?

UNO has not enough memory
I see errors regarding MAC Address (which I had to remove)

   /home/runner/Arduino/libraries/ArtNet/Artnet/ArtPollReply.h:68:15: warning: 'my_mac' is used uninitialized in this function [-Wuninitialized]
           memcpy(r.mac, my_mac, 6);
           ~~~~~~^~~~~~~~~~~~~~~~~~

MrFrangipane · 2024-01-08T22:27:31Z

Oh OK i was surprised to see it working, do you want me to remove this section from the readme as well ?

It’s great if you can! Thank you!

It's done, I copied the explanation you gave in #59

https://github.com/hideakitai/ArtNet/blob/b4df2244faa6df0d9837bcf8c3ecfa981039d0bf/README.md#subscribing-callbacks-with-net-sub-net-and-universe-as-you-like

Although I'm not sure what is meant by "making public 4 of them"

hideakitai · 2024-01-09T00:11:29Z

Although I'm not sure what is meant by "making public 4 of them"

PollReply has the information of four input/output ports. So current implementation is, you can subscribe many universes but four of them are informed by PollReply. (But this implementation is not preferred, so I should fix it https://art-net.org.uk/how-it-works/discovery-packets/artpollreply/)

hideakitai

Added suggestion for README

hideakitai · 2024-01-09T00:16:51Z

README.md

 - These universes (targets of the callbacks) are reflected to `net_sw` `sub_sw` `sw_in` in `ArtPollreply` automatically

+PortTypes, GoodInput/Output, SwIn, etc., are limited to 4 ports. If more than 4 callbacks are needed, it is better to subscribe to more than four and make public 4 of them


Suggested change

PortTypes, GoodInput/Output, SwIn, etc., are limited to 4 ports. If more than 4 callbacks are needed, it is better to subscribe to more than four and make public 4 of them

PortTypes, GoodInput/Output, SwIn, etc., are limited to 4 ports. Only the first four ports are reflected if you subscribe to more than four callbacks.

hideakitai · 2024-01-09T01:04:54Z

.github/workflows/build.yml

+          sketch-paths: |
+            - examples/EthernetENC


Following sketch-paths is better to avoid memory shortage for avr

Suggested change

sketch-paths: |

- examples/EthernetENC

sketch-paths: |

- examples/EthernetENC/receiver

- examples/EthernetENC/sender

hideakitai · 2024-01-09T01:10:07Z

.github/workflows/build.yml

+          - vendor: arduino
+            arch: avr
+            name: uno


Could you comment out these lines and add a comment like "temporarily disabled because of memory shortage of sender example"

https://github.com/hideakitai/ArtNet/actions/runs/7453947055/job/20282884214?pr=79

hideakitai · 2024-01-09T01:28:03Z

Artnet/Receiver.h

+#if !defined(ESP8266) && !defined(ARTNET_ETHER_IS_ENC28J60)
        Ethernet.MACAddress(mac);
 #endif


The latest (on GitHub) version has the MACAddress() method.

https://github.com/JAndrassy/EthernetENC/blob/3a50d3aa9c1510e4090d1763ec3e91c700b764a1/src/Ethernet.h#L99

So, could you modify these lines as follows? (ESP8266 also has MACAddress() method now, #if directive has removed)

Suggested change

#if !defined(ESP8266) && !defined(ARTNET_ETHER_IS_ENC28J60)

Ethernet.MACAddress(mac);

#endif

Ethernet.MACAddress(mac);

Hi,

I was able to compile my sketch after cloning the latest ENC library and removing the #if directive

Readme and workflow have been updated to use git instead of regular installation

hideakitai · 2024-01-09T01:30:30Z

@MrFrangipane Maybe the suggestions above can fix workflows. Could you try to implement them?

MrFrangipane · 2024-01-09T10:37:30Z

Although I'm not sure what is meant by "making public 4 of them"

PollReply has the information of four input/output ports. So current implementation is, you can subscribe many universes but four of them are informed by PollReply. (But this implementation is not preferred, so I should fix it https://art-net.org.uk/how-it-works/discovery-packets/artpollreply/)

Thank you ! I get it now :)

… readme

…oards

MrFrangipane · 2024-01-09T11:23:40Z

@MrFrangipane Maybe the suggestions above can fix workflows. Could you try to implement them?

Sure, changes have been made :)

I realized too late i could directly commit your suggestions, I'll know for next time

hideakitai · 2024-01-09T14:15:16Z

Ah, maybe this is a bug of EthernetENC…

MrFrangipane · 2024-01-09T16:01:47Z

Ah, maybe this is a bug of EthernetENC…

It says on EthernetENC's readme

For ESP32 it is better than using a MAC layer module like the enc28j60 to use a PHY layer LAN module like LAN8720 supported by the ESP32 MAC peripheral and the Arduino boards support package.

Should we drop ESP32 from those tests and state to not use ESP32 with EthernetENC in the readme ?

hideakitai · 2024-01-09T23:20:42Z

Please comment out esp32, s3, and c3 from workflow. But it is NOT unavailable for esp32 series, I will send pull request to EtherENC :)

hideakitai · 2024-01-09T23:25:45Z

state to not use ESP32 with EthernetENC in the readme ?

Could you add a same note as README of EtherENC?

For ESP32 it is better than using a MAC layer module like the enc28j60 to use a PHY layer LAN module like LAN8720 supported by the ESP32 MAC peripheral and the Arduino boards support package.

hideakitai · 2024-01-10T04:24:29Z

Created a PR on EthernetENC Networking-for-Arduino/EthernetENC#58

-> merged

.github/workflows/build.yml

…th was split)

hideakitai · 2024-01-10T07:26:58Z

If you finish working on this PR, please mention me!

…sable avr:uno memory shortage still going on)

…krvidor4000

MrFrangipane · 2024-01-10T08:15:18Z

Hi @hideakitai

Thank you for your help again !

I realized only 2 examples were compiled, so I added them to the workflow

sketch-paths: |
  - examples/EthernetENC/receive_fastled
  - examples/EthernetENC/receiver
  - examples/EthernetENC/send_receive
  - examples/EthernetENC/sender

This revealed that FastLED is not supporting mkrvidor4000 boards. What do you prefer ?

remove the board from tests and leave fastled enabled for the others
remove the FastLED tests for all boards and leave mkrvidor4000 board enabled

I checked the other workflows and they seem to correspond to the 2nd option. The current version of the workflow is as follows

sketch-paths: |
  - examples/EthernetENC/receiver
  - examples/EthernetENC/send_receive
  - examples/EthernetENC/sender
# disabled due to FastLED not supporting mkrvidor4000
# - examples/EthernetENC/receive_fastled

If this is OK for you, merging should be OK 🥳

hideakitai · 2024-01-10T08:24:25Z

Thank you! Yeah, mkrvidor is not supported. Hmm.. I prefer

remove the board from tests and leave fastled enabled for the others

MrFrangipane · 2024-01-10T08:34:13Z

Thank you! Yeah, mkrvidor is not supported. Hmm.. I prefer

remove the board from tests and leave fastled enabled for the others

@hideakitai board has been disabled and FastLED reinstated

All tests seems to have passed :)

hideakitai · 2024-01-10T08:41:55Z

All checks passed, thank you! I'll review the code again :)

hideakitai

There is one typo, but LGTM

README.md

Co-authored-by: Hideaki Tai <hideaki.tai@gmail.com>

MrFrangipane · 2024-01-10T08:53:52Z

There is one typo, but LGTM

Suggested fix was commited :)

hideakitai · 2024-01-10T09:02:10Z

Thank you for your contribution!

hideakitai · 2024-01-10T09:03:12Z

Please close #80 :) Thanks again!

MrFrangipane · 2024-01-10T09:10:27Z

Awesome !

Thank you for all those wonderful libraries 🙏

Create ArtnetEtherENC.h

70f6966

Allows to use https://github.com/JAndrassy/EthernetENC

MrFrangipane mentioned this pull request Jan 5, 2024

Allow to use ENC28J60 Ethernet module #80

Closed

fix mac address error when using EthernetENC

0121a64

MrFrangipane force-pushed the main branch from c7b8ac2 to 0121a64 Compare January 5, 2024 15:50

hideakitai requested changes Jan 5, 2024

View reviewed changes

MrFrangipane added 5 commits January 8, 2024 11:48

try to add examples and workflows

a5aa0dd

fix readme

67d4d45

fix readme

dd1b268

fix readme

5c82eec

make notes about ENC28J60 collapsible/exandable

9312719

hideakitai reviewed Jan 8, 2024

View reviewed changes

MrFrangipane added 2 commits January 8, 2024 15:56

modify build for ENC28J60 to support any platform + fix readme

d89e9ec

fix build tabulation

519fa04

add explanation for 4 callacks limitation

b4df224

hideakitai reviewed Jan 9, 2024

View reviewed changes

remove MAC address condition (latest github ENC supports it) + update…

c4a09e8

… readme

MrFrangipane added 3 commits January 9, 2024 12:13

remove avr:uno from workflow / fix lib url from workflow

af4f950

fix(workflow): split sketch-path to reduce memory footprint for avr b…

78d82d1

…oards

fix(readme): use suggested formulation for ArtPoll explanation

c447be0

MrFrangipane added 2 commits January 9, 2024 17:06

fix: remove unused svg file

ed18b37

fix(ArtnetEntherENC.h): remove unused directive

ad5dd56

hideakitai reviewed Jan 10, 2024

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

test(workflow): enable avr:uno to check memory usage (since sketch-pa…

b4cb6d3

…th was split)

MrFrangipane added 3 commits January 10, 2024 08:33

test(workflows/ethernetENC): add fastled and send_receive folders (di…

05f2288

…sable avr:uno memory shortage still going on)

fix(workflows/ethernetENC): name folders correctly

9ddd952

fix(workflows/ethernetENC): remove FastLED because not supported by m…

c04d767

…krvidor4000

fix(workflows/ethernetENC): remove mkrvidor4000 and reinstate FastLED

743aa1c

hideakitai approved these changes Jan 10, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

72f22b9

Co-authored-by: Hideaki Tai <hideaki.tai@gmail.com>

hideakitai merged commit 41ee725 into hideakitai:main Jan 10, 2024
32 checks passed

		- These universes (targets of the callbacks) are reflected to `net_sw` `sub_sw` `sw_in` in `ArtPollreply` automatically

		PortTypes, GoodInput/Output, SwIn, etc., are limited to 4 ports. If more than 4 callbacks are needed, it is better to subscribe to more than four and make public 4 of them

Create ArtnetEtherENC.h #79

Create ArtnetEtherENC.h #79

Conversation

MrFrangipane commented Jan 5, 2024

hideakitai left a comment

Choose a reason for hiding this comment

MrFrangipane commented Jan 7, 2024

MrFrangipane commented Jan 8, 2024 • edited Loading

MrFrangipane commented Jan 8, 2024

hideakitai commented Jan 8, 2024

hideakitai left a comment

Choose a reason for hiding this comment

hideakitai Jan 8, 2024

Choose a reason for hiding this comment

MrFrangipane Jan 8, 2024

Choose a reason for hiding this comment

hideakitai Jan 8, 2024

Choose a reason for hiding this comment

MrFrangipane Jan 8, 2024

Choose a reason for hiding this comment

MrFrangipane commented Jan 8, 2024

hideakitai commented Jan 8, 2024

MrFrangipane commented Jan 8, 2024

MrFrangipane commented Jan 8, 2024 • edited Loading

hideakitai commented Jan 9, 2024

hideakitai left a comment

Choose a reason for hiding this comment

hideakitai Jan 9, 2024

Choose a reason for hiding this comment

hideakitai Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

hideakitai Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

hideakitai Jan 9, 2024

Choose a reason for hiding this comment

MrFrangipane Jan 9, 2024

Choose a reason for hiding this comment

hideakitai commented Jan 9, 2024

MrFrangipane commented Jan 9, 2024

MrFrangipane commented Jan 9, 2024

hideakitai commented Jan 9, 2024

MrFrangipane commented Jan 9, 2024

hideakitai commented Jan 9, 2024

hideakitai commented Jan 9, 2024

hideakitai commented Jan 10, 2024 • edited Loading

hideakitai commented Jan 10, 2024

MrFrangipane commented Jan 10, 2024 • edited Loading

hideakitai commented Jan 10, 2024 • edited Loading

MrFrangipane commented Jan 10, 2024

hideakitai commented Jan 10, 2024

hideakitai left a comment

Choose a reason for hiding this comment

MrFrangipane commented Jan 10, 2024

hideakitai commented Jan 10, 2024

hideakitai commented Jan 10, 2024

MrFrangipane commented Jan 10, 2024

MrFrangipane commented Jan 8, 2024 •

edited

Loading

MrFrangipane commented Jan 8, 2024 •

edited

Loading

hideakitai Jan 9, 2024 •

edited

Loading

hideakitai Jan 9, 2024 •

edited

Loading

hideakitai commented Jan 10, 2024 •

edited

Loading

MrFrangipane commented Jan 10, 2024 •

edited

Loading

hideakitai commented Jan 10, 2024 •

edited

Loading