Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable license checks in spotless to be more flexible/configurable #48

Closed
rbarkerSL opened this issue Dec 18, 2024 · 2 comments · Fixed by #49
Closed

enable license checks in spotless to be more flexible/configurable #48

rbarkerSL opened this issue Dec 18, 2024 · 2 comments · Fixed by #49
Assignees
Milestone

Comments

@rbarkerSL
Copy link
Contributor

Should be able to configure whether spotless uses the SPDX convention for license checks or not.

@jjohannes
Copy link
Contributor

We should first clarify if this is really needed. I think on the long run, all repos will use the short and simple SPDX convention header.

But if we need it, I would suggest to implement it like this:

  • Optionally, a repository can contain a file gralde/license-header.txt. If (and only if) that files exists, the content of the files is taken as header. Otherwise, we default to what we have now.

cc @hendrikebbers

@jsync-swirlds
Copy link

There may be cases where an organization wants to use this plugin for consistency across both Heiro contributions and internal codebases that may, or may not, eventually be contributed to Heiro.
Allowing for internal headers that are not SPDX (because those internal codebases are not "open" licensed) as an option makes it easier for those organizations to contribute.

The proposed mechanism appears, to me, to be a good way to enable that flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants