Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not change license header to SPDX format #17132

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jjohannes
Copy link
Collaborator

Description:

Reverts moving to a new license header already, which was part of #15282

Related issue(s):
#15282
hiero-ledger/hiero-gradle-conventions#48

Notes for reviewer:

Checklist

  • Tested (unit, integration, etc.)

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@jjohannes jjohannes added this to the v0.58 milestone Dec 19, 2024
@jjohannes jjohannes self-assigned this Dec 19, 2024
@jjohannes jjohannes requested review from a team as code owners December 19, 2024 07:39
Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1128c74) 95476 64916 67.99%
Head commit (98dd6f8) 95476 (+0) 64912 (-4) 67.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17132) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (1128c74) to head (98dd6f8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17132      +/-   ##
=============================================
- Coverage      64.25%   64.24%   -0.01%     
+ Complexity     20819    20818       -1     
=============================================
  Files           2547     2547              
  Lines          95713    95713              
  Branches       10014    10014              
=============================================
- Hits           61498    61494       -4     
- Misses         30606    30610       +4     
  Partials        3609     3609              

see 6 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjohannes jjohannes merged commit 0bb55fe into develop Dec 19, 2024
63 checks passed
@jjohannes jjohannes deleted the 14255-revert-license-header-change branch December 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants