Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include/includes #45

Closed
ericbottard opened this issue Jul 16, 2014 · 6 comments
Closed

Add include/includes #45

ericbottard opened this issue Jul 16, 2014 · 6 comments

Comments

@ericbottard
Copy link

See discussion at #39

One should be able to apply include rules (in addition to exclude rules) to the files being considered.

Namely:
no include, no exclude => all files in the source sets should be considered
include(s) => only files matching the includes should be considered
exclude(s) => all files except those matching the excludes
include(s) + excludes(s) => only files matching the includes but not matching the excludes

@ericbottard
Copy link
Author

Tried with the configuration below (I would have added package-info.java as an exclude later, but wanted to start gently) on Spring XD, but the plugin did not trigger. I suspect the UP-TO-DATE check done by gradle does not take into account the includes/excludes.

    license {
        header rootProject.file('src/etc/header.txt')
        skipExistingHeaders true
        ext.year = Calendar.getInstance().get(Calendar.YEAR)
        mapping {
            java='SLASHSTAR_STYLE'
        }
        includes(['**/*.java'])
    }

@ericbottard
Copy link
Author

My bad, testing against a tree where some headers had been added already. Will need some more time to make sure this works, sorry

@hierynomus
Copy link
Owner

No problem! Keep me posted.

2014-07-16 14:27 GMT+02:00 Eric Bottard notifications@github.com:

My bad, testing against a tree where some headers had been added already.
Will need some more time to make sure this works, sorry


Reply to this email directly or view it on GitHub
#45 (comment)
.

@ericbottard
Copy link
Author

OK, everything seems to be in order, thanks for that quick feedback loop!

If you can cut a release on maven central, we'll be happy to use it.

@hierynomus
Copy link
Owner

Coming up...

2014-07-16 15:00 GMT+02:00 Eric Bottard notifications@github.com:

OK, everything seems to be in order, thanks for that quick feedback loop!

If you can cut a release on maven central, we'll be happy to use it.


Reply to this email directly or view it on GitHub
#45 (comment)
.

@hierynomus
Copy link
Owner

v0.10.0 is released, will be synced to maven-central soon.

2014-07-16 15:01 GMT+02:00 Jeroen van Erp jeroen@javadude.nl:

Coming up...

2014-07-16 15:00 GMT+02:00 Eric Bottard notifications@github.com:

OK, everything seems to be in order, thanks for that quick feedback loop!

If you can cut a release on maven central, we'll be happy to use it.


Reply to this email directly or view it on GitHub
#45 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants