Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor changes #291

Merged
merged 2 commits into from
Dec 21, 2016
Merged

Two minor changes #291

merged 2 commits into from
Dec 21, 2016

Conversation

solind
Copy link

@solind solind commented Dec 21, 2016

  1. We shouldn't assume that the current thread context ClassLoader has access to the sshj.properties file, but it's safe to assume that the DefaultConfig class's ClassLoader does.

  2. When creating an SSHRuntimeException based on a Throwable, I believe the SSHRuntimeException should adopt the message of the Throwable cause (instead of always using null).

WDYT?

@hierynomus hierynomus merged commit b6f437a into hierynomus:master Dec 21, 2016
@hierynomus
Copy link
Owner

Agreed on both accounts :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants