Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SFTPClient.mkdirs to not inadvertently prefix with '/' #415

Merged
merged 4 commits into from
Aug 2, 2018

Conversation

hierynomus
Copy link
Owner

@dkocher Could I ask you to verify whether this does not break in Cyberduck. The old sftp testcases were somewhat limited, so I hope you have some additional cases ;)

@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #415 into master will increase coverage by 0.21%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #415      +/-   ##
===========================================
+ Coverage     55.28%   55.5%   +0.21%     
- Complexity     1182    1189       +7     
===========================================
  Files           192     192              
  Lines          7776    7785       +9     
  Branches        702     704       +2     
===========================================
+ Hits           4299    4321      +22     
+ Misses         3127    3115      -12     
+ Partials        350     349       -1
Impacted Files Coverage Δ Complexity Δ
...ain/java/net/schmizz/sshj/sftp/PathComponents.java 85% <100%> (+20.71%) 11 <4> (+4) ⬆️
...rc/main/java/net/schmizz/sshj/sftp/PathHelper.java 82.6% <87.5%> (+2.6%) 12 <7> (ø) ⬇️
src/main/java/net/schmizz/sshj/SSHClient.java 58.28% <0%> (-0.62%) 32% <0%> (-1%)
...zz/sshj/connection/channel/ChannelInputStream.java 76.11% <0%> (+2.98%) 16% <0%> (+1%) ⬆️
...rc/main/java/net/schmizz/sshj/sftp/SFTPEngine.java 59.45% <0%> (+3.6%) 23% <0%> (+1%) ⬆️
...rc/main/java/net/schmizz/sshj/sftp/SFTPClient.java 33.78% <0%> (+5.4%) 9% <0%> (+1%) ⬆️
...t/schmizz/sshj/connection/ConnectionException.java 44.44% <0%> (+11.11%) 4% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7556a7f...2227683. Read the comment docs.

Repository owner deleted a comment Jun 11, 2018
Repository owner deleted a comment Jun 19, 2018
Repository owner deleted a comment Aug 2, 2018
@hierynomus hierynomus merged commit deff097 into master Aug 2, 2018
@hierynomus hierynomus deleted the fix-sftp-mkdirs branch August 3, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants