Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid key leakage. #627

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

xSeagullx
Copy link
Contributor

In some cases, current code will leak parts or even the whole ssh key if it's slightly malformed.
One example of that malformation will be a key, where all newlines are replaced by other character, thus turning a multiline key to a single big string.
Then that whole line will be leaked to exception message. Thus I suggest to completely remove any parts of key from getting into the exception.

In some cases, current code will leak parts or even the whole ssh key if it's slightly malformed.
One example of that malformation will be a key, where all newlines are replaced by other character, thus turning a multiline key to a single big string.
Then that whole line will be leaked to exception message.
@xSeagullx xSeagullx changed the title Avoid key lleakage. Avoid key leakage. Aug 20, 2020
@hierynomus hierynomus merged commit a0d7b7f into hierynomus:master Aug 25, 2020
@xSeagullx xSeagullx deleted the avoid-key-leakage branch August 28, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants