Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeepAlive and RemotePF examples #791

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

exceptionfactory
Copy link
Contributor

As requested in issue #784, this pull request updates the KeepAlive example class to set the KeepAlive interval prior to connecting, following the behavior adjustments introduced in SSHJ 0.33.0. The RemotePF example follows the same approach for the Heartbeat setting, and removes the call to Transport.setHeartbeatInterval(), which is no longer defined.

- Set KeepAlive interval before connecting
@codecov-commenter
Copy link

Codecov Report

Merging #791 (60bf3bd) into master (3de0302) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #791      +/-   ##
============================================
- Coverage     64.75%   64.72%   -0.04%     
+ Complexity     1479     1477       -2     
============================================
  Files           211      211              
  Lines          8660     8660              
  Branches        812      812              
============================================
- Hits           5608     5605       -3     
- Misses         2620     2623       +3     
  Partials        432      432              
Impacted Files Coverage Δ
src/main/java/net/schmizz/keepalive/KeepAlive.java 74.07% <ø> (ø)
...t/schmizz/sshj/connection/ConnectionException.java 33.33% <0.00%> (-11.12%) ⬇️
...zz/sshj/connection/channel/ChannelInputStream.java 76.92% <0.00%> (-3.08%) ⬇️
...in/java/net/schmizz/sshj/common/SecurityUtils.java 46.87% <0.00%> (-1.05%) ⬇️
.../main/java/net/schmizz/sshj/sftp/PacketReader.java 95.74% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de0302...60bf3bd. Read the comment docs.

@jkosternl
Copy link

Good addition @exceptionfactory. @hierynomus, can you merge this one in please? I had issues with the examples, as what this PR fixes.

@hierynomus hierynomus merged commit c0f6000 into hierynomus:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants