-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds fallback to posix-rename@openssh.com extension if possible and c… #827
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9f8bcc2
adds fallback to posix-rename@openssh.com extension if possible and c…
7a580f3
Adds '{}' around if/else statements
c6c4849
adds basic tests for file rename
cbb88ab
Merge remote-tracking branch 'origin/openssh-posix-rename' into opens…
13ed40b
fix comments
274d4e9
fixes indentation
ca16124
Merge remote-tracking branch 'origin/openssh-posix-rename' into opens…
19a84bb
Merge branch 'master' into openssh-posix-rename
hierynomus 837fa96
adds helper methods to make existing sftp rename tests more concise
c6099d9
adds basic test for atomic rewrite
23c538d
adds possibility to request a specific client version (e.g. for testi…
981d268
adds testcases for SFTP rename flags fallback behaviour
4205bb7
Merge branch 'master' into openssh-posix-rename
klelifo ab6f994
refactoring to make SFTPEngine.init(int requestedVersion) protected
4ebf6ad
Merge branch 'openssh-posix-rename' of github.com:klelifo/sshj into o…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add
{
around the if-statement... Everywhere where that's not done is a leftover ;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, i just pushed a corrected version.
Thanks for your quick reply.