Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(upgrade): Remove empty react-native.config.js #219

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

tocalvo
Copy link
Contributor

@tocalvo tocalvo commented Aug 8, 2022

Hi!
The file looks empty but give and error when i try to upgrade to react-native 0.69.3 due to the change on the cli and the deprecated fields hooks and assets.

The react-native-cli update: https://github.com/react-native-community/cli/releases/tag/v8.0.0
and this is the change : react-native-community/cli#1537

I was searching about the reason to add the file with empty values looking in the old cli doc:
https://github.com/react-native-community/cli/blob/6615eb30f37bec5bb25acc066c849c4aa2d8a4cd/docs/dependencies.md

But can see any clue about. The fields are empty so seems that can be deleted the whole file.

I try this with my own app. it works, compile without errors and still work the fingerprint scan.

Fixes #243

@mikehardy
Copy link
Collaborator

someone just logged an issue about the same thing, I don't have the time to do a release (I'm not really a maintainer here...) but this will at least make a git reference to current code work, thanks!

@mikehardy mikehardy merged commit 59eadde into hieuvp:master Feb 27, 2023
@mikehardy mikehardy mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on run android
2 participants