Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hifis.keepalived role #215

Merged
merged 2 commits into from
May 16, 2024
Merged

Add hifis.keepalived role #215

merged 2 commits into from
May 16, 2024

Conversation

Normo
Copy link
Member

@Normo Normo commented May 15, 2024

@Normo Normo added this to the v4.1.0 milestone May 15, 2024
@Normo Normo self-assigned this May 15, 2024
@Normo Normo marked this pull request as ready for review May 15, 2024 14:03
@Normo Normo requested a review from a team as a code owner May 15, 2024 14:03
@Normo Normo force-pushed the 214-add-keepalived-role branch 2 times, most recently from 9c8b6f8 to ece74eb Compare May 16, 2024 08:28
@Normo
Add hifis.keepalived role
19ca7ac 
Signed-off-by: Norman Ziegner <n.ziegner@hzdr.de>
@Normo Normo requested a review from tobiashuste May 16, 2024 08:42
Normo
Normo commented May 16, 2024
View reviewed changes
roles/keepalived/README.md Outdated Show resolved Hide resolved
tobiashuste
tobiashuste previously approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Except of your own suggestion I have no more wishes. Thanks!

@Normo Normo enabled auto-merge May 16, 2024 10:28
@Normo Normo disabled auto-merge May 16, 2024 10:29
@Normo Normo merged commit e91fe9d into hifis-net:main May 16, 2024
7 checks passed
@Normo Normo deleted the 214-add-keepalived-role branch May 16, 2024 10:39
@Normo Normo added the keepalived Related to hifis.keepalived role label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiashuste tobiashuste tobiashuste left review comments

Assignees

@Normo Normo

Labels
keepalived Related to hifis.keepalived role
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Include hifis.keepalived role into collection
2 participants
@Normo @tobiashuste