Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dnf instead of yum module #232

Merged
merged 1 commit into from
May 21, 2024
Merged

Use dnf instead of yum module #232

merged 1 commit into from
May 21, 2024

Conversation

Normo
Copy link
Member

@Normo Normo commented May 21, 2024

Fixes ansible-lint error:

fqcn[action-core]: Use FQCN for builtin module actions (ansible.builtin.yum).
roles/zammad/tasks/install.yml:12 Use ansible.builtin.dnf or ansible.legacy.dnf instead.

@Normo
Use ansible.builtin.dnf instead of yum module
af3af37 
Signed-off-by: Norman Ziegner <n.ziegner@hzdr.de>
@Normo Normo self-assigned this May 21, 2024
@Normo Normo requested a review from a team as a code owner May 21, 2024 09:32
@github-actions github-actions bot added the zammad Related to role hifis.zammad label May 21, 2024
@Normo Normo requested a review from tobiashuste May 21, 2024 10:15
@Normo Normo added the bug Something isn't working label May 21, 2024
@Normo Normo added this to the v4.2.0 milestone May 21, 2024
christianhueserhzdr
christianhueserhzdr approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@christianhueserhzdr christianhueserhzdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Norman @Normo, for exchanging these modules to fix the linting violation.

@christianhueserhzdr christianhueserhzdr merged commit 3f45604 into hifis-net:main May 21, 2024
8 checks passed
@Normo Normo deleted the fix-ansible-lint branch May 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhueserhzdr christianhueserhzdr christianhueserhzdr approved these changes

@tobiashuste tobiashuste Awaiting requested review from tobiashuste

Assignees

@Normo Normo

Labels
bug Something isn't working zammad Related to role hifis.zammad
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Normo @christianhueserhzdr