-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sideEffect: false, stops webpack importing css #3504
Closed
domarmstrong opened this issue
Mar 16, 2022
· 4 comments
· Fixed by #3511 · 4 remaining pull requests
Closed
sideEffect: false, stops webpack importing css #3504
domarmstrong opened this issue
Mar 16, 2022
· 4 comments
· Fixed by #3511 · 4 remaining pull requests
Labels
Comments
History #3396. @shakyShane Any thoughts? Do we instead need something like |
Pushing 11.5.1 now. |
1 task
Confirming that the fix is working 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue/behavior that seems buggy
In 11.5.0,
sideEffects: false
was added to thepackage.json
. This has stopped the styles being imported by webpack which now sees it as an unused zero side effect file. See webpack-contrib/mini-css-extract-plugin#102 (comment).The text was updated successfully, but these errors were encountered: