Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sideEffect: false, stops webpack importing css #3504

Closed
domarmstrong opened this issue Mar 16, 2022 · 4 comments · Fixed by #3511 · 4 remaining pull requests
Closed

sideEffect: false, stops webpack importing css #3504

domarmstrong opened this issue Mar 16, 2022 · 4 comments · Fixed by #3511 · 4 remaining pull requests
Labels
bug help welcome Could use help from community parser

Comments

@domarmstrong
Copy link

Describe the issue/behavior that seems buggy

In 11.5.0, sideEffects: false was added to the package.json. This has stopped the styles being imported by webpack which now sees it as an unused zero side effect file. See webpack-contrib/mini-css-extract-plugin#102 (comment).

@domarmstrong domarmstrong added bug help welcome Could use help from community parser labels Mar 16, 2022
@joshgoebel
Copy link
Member

History #3396. @shakyShane Any thoughts? Do we instead need something like sideEffects: ["*.css"]? I'm not really familiar with this in detail.

@verhovsky
Copy link
Contributor

verhovsky commented Apr 10, 2022

could I get a 11.5.1 release just with this change please? everyone who uses webpack (the most popular build tool) for their website that upgrades highlight.js will break their site essentially
Screen Shot 2022-04-09 at 18 58 39

Screen Shot 2022-04-09 at 18 58 25

@joshgoebel
Copy link
Member

Pushing 11.5.1 now.

@limonte
Copy link

limonte commented Apr 11, 2022

Confirming that the fix is working 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment