-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for SAS language #1165
Conversation
@isagalaev can we consider adding SAS to hljs? Currently pulling in his work here from https://github.com/mcaceresb/highlight-sas-stata in order to achieve this. |
@isagalaev please add SAS Language to highlight.js |
The PR seems to be fine, is there any reason why it has not been accepted? |
See if the new SAS language file follows new policy and new rules released in the updated documentation. |
@gusbemacbe I'm not entirely sure what you mean? I followed the language contribution guide which does not seem to have changed. |
Ah, Maurice, I saw you sent the external documentation. Maybe in the next release the external documentation must be changed. |
@gusbemacbe Do you mean that the docs are not updated? I diffed the .rst files I had locally 2 years ago with the master branch. The changes seemed like minor clarifications and I did not see anything I missed in my original submission. |
See: #1759 |
Ok; it is not clear to me what I need to do based on that. Apologies if it supposed to be evident. |
@gusbemacbe would you be able to give some directions on what is left open. We are relying on this feature and currently as @mcaceresb I don't see what is to be done. Do we have to wait for #1759 ? |
This looks good. I'm not seeing any blockers @gusbemacbe? |
@marcoscaceres Based on #1759, are you planning to move some smaller languages, like SAS, into separate NPM libraries? |
No. Not for at least 1 year until as a community we figure out how to do it. |
Could someone please send a PR for updating the CHANGES.md file? |
@marcoscaceres Please see #1841 |
No description provided.