Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SAS language #1165

Merged
merged 6 commits into from
Sep 11, 2018
Merged

Conversation

mcaceresb
Copy link
Contributor

No description provided.

@Sannis Sannis changed the title Added support for SAS language. Added support for SAS language May 9, 2016
@tglines
Copy link

tglines commented Dec 21, 2017

@isagalaev can we consider adding SAS to hljs? Currently pulling in his work here from https://github.com/mcaceresb/highlight-sas-stata in order to achieve this.

@77QingLiu
Copy link

@isagalaev please add SAS Language to highlight.js

@antonsarov
Copy link
Contributor

The PR seems to be fine, is there any reason why it has not been accepted?

@gusbemacbe
Copy link
Contributor

See if the new SAS language file follows new policy and new rules released in the updated documentation.

@mcaceresb
Copy link
Contributor Author

@gusbemacbe I'm not entirely sure what you mean? I followed the language contribution guide which does not seem to have changed.

@gusbemacbe
Copy link
Contributor

Then, Maurice, let me call @ldct and @SirCmpwn to review and approve.

Please wait for the approval.

@gusbemacbe
Copy link
Contributor

Ah, Maurice, I saw you sent the external documentation. Maybe in the next release the external documentation must be changed.

@mcaceresb
Copy link
Contributor Author

mcaceresb commented Jul 23, 2018

@gusbemacbe Do you mean that the docs are not updated? I diffed the .rst files I had locally 2 years ago with the master branch. The changes seemed like minor clarifications and I did not see anything I missed in my original submission.

@gusbemacbe
Copy link
Contributor

See: #1759

@mcaceresb
Copy link
Contributor Author

Ok; it is not clear to me what I need to do based on that. Apologies if it supposed to be evident.

@antonsarov
Copy link
Contributor

@gusbemacbe would you be able to give some directions on what is left open. We are relying on this feature and currently as @mcaceresb I don't see what is to be done. Do we have to wait for #1759 ?

@marcoscaceres
Copy link
Contributor

This looks good. I'm not seeing any blockers @gusbemacbe?

@kylebarron
Copy link

@marcoscaceres Based on #1759, are you planning to move some smaller languages, like SAS, into separate NPM libraries?

@marcoscaceres
Copy link
Contributor

No. Not for at least 1 year until as a community we figure out how to do it.

@marcoscaceres marcoscaceres merged commit be04585 into highlightjs:master Sep 11, 2018
@marcoscaceres
Copy link
Contributor

Could someone please send a PR for updating the CHANGES.md file?

@antonsarov
Copy link
Contributor

@marcoscaceres Please see #1841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants