Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tools/developer.html #3776

Merged

Conversation

shabbir23ah
Copy link
Contributor

@shabbir23ah shabbir23ah commented May 1, 2023

I have updated tools/developer.html as described on issue #3729

Changes

3 lines changed and 2 new lines added

Checklist

  • Tested nodejs build

I have updated tools/developer.html as described  on issue highlightjs#3729
@joshgoebel
Copy link
Member

Awesome. Lets add a changelog entry please.

@shabbir23ah
Copy link
Contributor Author

Is this format correct for changelog?

Parser:

      - Replaced the old `hljs.highlight()` function call with the new one, as per the suggestion in the GitHub issue #3729.
      - Removed the click event binding for the `#update-highlighting` button and replaced it with a new `update()` function.
      - Added a `change` event listener for the `.languages` element that also triggers the `update()` function.

@joshgoebel
Copy link
Member

And with a link/subscript to your GitHub, etc... just follow the pattern that's already there and I can edit it if it's not quite right.

I have updated my work on CHANGES.md
@shabbir23ah
Copy link
Contributor Author

Updated changelog on CHANGES.md

@joshgoebel joshgoebel merged commit bc56b4e into highlightjs:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants