Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python self #4025

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Python self #4025

merged 3 commits into from
Mar 23, 2024

Conversation

lfalin
Copy link
Contributor

@lfalin lfalin commented Mar 22, 2024

This change assigns a scope to the self variable in Python, similar to the PHP definition. This variable was already identified in the grammar parser (presumably for recognition), but no scope was assigned.

Resolves #4024

Changes

  • Assigns a scope to the self variable in the python language definition.
  • Adds a markup test for the above change.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

src/languages/python.js Outdated Show resolved Hide resolved
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +46 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +3 B
es/highlight.min.js 8.2 KB 8.2 KB +3 B
es/languages/python.min.js 1.56 KB 1.58 KB +19 B
highlight.min.js 8.23 KB 8.23 KB +3 B
languages/python.min.js 1.57 KB 1.58 KB +18 B

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +50 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +4 B
es/highlight.min.js 8.2 KB 8.2 KB +4 B
es/languages/python.min.js 1.56 KB 1.58 KB +19 B
highlight.min.js 8.23 KB 8.23 KB +5 B
languages/python.min.js 1.57 KB 1.58 KB +18 B

@joshgoebel joshgoebel merged commit 0d7061c into highlightjs:main Mar 23, 2024
15 checks passed
@lfalin lfalin deleted the python-self branch March 23, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighting the self variable in Python
2 participants