-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erlang/OTP 27 enhancements #4063
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +446 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +477 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +455 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +429 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +324 B View Changes
|
src/languages/erlang.js
Outdated
match: /"""("*)(?!")(.|\n)*?"""\1/, | ||
match: /"""("*)(?!")[\s\S]*?"""\1/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the nuance here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just looking at the code for the BACKSLASH_ESCAPE and I thought it made a bit more sense than (.|\n)
.
Taking a look at the failing tests now. I was sure I ran a check before I pushed... |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +304 B View Changes
|
Silly mistake, after I made sure everything worked I went ahead and sorted the variants like the documentation
But placing the triple-quote matcher at the end made it prioritise the regular "" matcher above it. |
Looking good. Rebase and add changelog? |
https://www.erlang.org/blog/highlights-otp-27/ https://www.erlang.org/doc/system/data_types#string Test examples taken from the blog and the documentation.
The doc/moduledoc attributes can contain strings without params so I've adjusted the directive segment to accomodate this. https://www.erlang.org/blog/highlights-otp-27/ https://www.erlang.org/doc/system/documentation Also added some missing directives: https://www.erlang.org/doc/system/modules#pre-defined-module-attributes
This one is the most involved change. https://www.erlang.org/blog/highlights-otp-27/ https://www.erlang.org/doc/system/data_types#sigil
Lifted from csharp
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +305 B View Changes
|
I hope that looks good. |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +308 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +308 B View Changes
|
Changes
Erlang/OTP version 27 carried a bunch of syntax enhancements.
They are summarized over on their blog: https://www.erlang.org/blog/highlights-otp-27/
I've split up each feature into its own commit so far.
These are:
Checklist
CHANGES.md
Please let me know how it looks.