Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(lua) add 'pluto' as an alias #4110

Merged
merged 2 commits into from
Sep 20, 2024
Merged

enh(lua) add 'pluto' as an alias #4110

merged 2 commits into from
Sep 20, 2024

Conversation

Sainan
Copy link
Contributor

@Sainan Sainan commented Sep 1, 2024

Rationale: My understanding is that the aliases are used for file extension matching. Pluto is a fork of Lua that uses the .pluto extension. There would be benefit for its users if .pluto files were recognised and highlighted as Lua by this package.

There are some differences in syntax, but I don't want to impose the burden of you having to maintain highlighting for it.

Sainan and others added 2 commits September 1, 2024 12:03
Rationale: My understanding is that the aliases are used for file extension matching. [Pluto](https://pluto-lang.org/) is a fork of Lua that uses the .pluto extension. There would be benefit for its users if .pluto files were recognised and highlighted as Lua by this package.

There are some differences in syntax, but I don't want to impose the burden of you having to maintain highlighting for it.
@joshgoebel
Copy link
Member

Sorry for pushing to your main, suggest you learn to use branches for PRs in the future.

Thanks for the contrib!

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +17 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -2 B
es/highlight.min.js 8.18 KB 8.18 KB -2 B
es/languages/lua.min.js 1.11 KB 1.13 KB +11 B
highlight.min.js 8.22 KB 8.22 KB -1 B
languages/lua.min.js 1.12 KB 1.13 KB +11 B

@joshgoebel joshgoebel merged commit 5543529 into highlightjs:main Sep 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants