-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Cybertopia themes #4124
add Cybertopia themes #4124
Conversation
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
3 files changedTotal change -3 B View Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
3 files changedTotal change -3 B View Changes
|
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
3 files changedTotal change +4 B View Changes
|
I almost forgot about I'll also try to find the time to fix the accessibiltiy checks to work with variables - since we also care about the accessibility of our themes out of the box. |
Great suggestion, I'll run checkTheme.js as asked in theme-guide and add the missing styles. For accessibility, I checked the contrast against WCAG at https://webaim.org/resources/contrastchecker/. |
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
2 files changedTotal change +2 B View Changes
|
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
3 files changedTotal change +3 B View Changes
|
Could you please rebase to resolve conflicts? |
Build Size ReportChanges to minified artifacts in 4 Added FilesView Changes
3 files changedTotal change -8 B View Changes
|
Boom. Merged! Thanks so much. |
Thank you for the guidance. |
New theme with 4 variants, source here (with screenshots): https://github.com/noraj/cybertopia-highlightjs