Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vue as 3rd party language #4167

Closed
wants to merge 1 commit into from
Closed

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Nov 11, 2024

No description provided.

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -6 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -2 B
es/highlight.min.js 8.18 KB 8.18 KB -2 B
highlight.min.js 8.22 KB 8.22 KB -2 B

@joshgoebel
Copy link
Member

Please see our 3rd party guide. You can use our own build process to create the dist folder which you can then check into your project - that will provide a packaged and ready to go versions (CJS and ES6) that can just be dropped into a browser - like how all our CDN grammars are packaged.

@noraj
Copy link
Contributor Author

noraj commented Nov 12, 2024

Please see our 3rd party guide. You can use our own build process to create the dist folder which you can then check into your project - that will provide a packaged and ready to go versions (CJS and ES6) that can just be dropped into a browser - like how all our CDN grammars are packaged.

Hi 👋🏻, I'm not sure to understand that comment. I saw SUPPORTED_LANGUAGES.md was listing the natively supported languages as well as the languages supported via 3rd party repositories. I saw a 3rd party repository existed for Vue.js but was missing from the list. I thought it was a mistake, so I PRed so it is listed.

As you mentioned it, I quickly checked docs/language-contribution.rst and extra/3RD_PARTY_QUICK_START.md. Maybe you mean the state the vue repository is in is so that it's not ready? But by no mean I meant to offer to maintain it.

@joshgoebel
Copy link
Member

Yeah this isn't ready/good to use as is, we'd like it to be "drop in" line every other grammar we publish.

@joshgoebel joshgoebel closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants