-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename groupId, maven artifactId to org.jvnet.jaxb / jaxb-maven-plugin #263
Conversation
@laurentschoelens go ahead and rebase this one now, i just released 0.15.3 |
6ac298b
to
26383bd
Compare
Not an expert on rebase but I guess my new commit will do the job 😄 |
@mattrpav : done highsource/jaxb2-basics#167 to jaxb2-basics to fix one issue. Guess we should do the renaming part too there (like org.jvnet.jaxb.commons package, org.jvnet.jaxb.commons groupid ?) by removing jaxb2 ref ? |
@laurentschoelens ready for the version bump and rename change for 2.x Be sure you have a remote tracking branch linked to your fork
Should show something like this:
With 'origin' as your forked repo. Do this git flow to rebase
Moving forward, let's name branches for the issue like this: Example branch for issue #267
|
Without the interactive rebase, that's what I did |
26383bd
to
4371703
Compare
Rebase done and forced push to my repository. PR updated according to latest changes. |
… / jaxb-maven-plugin
4371703
to
0471cb9
Compare
|
||
import org.apache.maven.plugin.MojoExecutionException; | ||
|
||
public interface OptionsFactory<O> { | ||
public interface IOptionsFactory<O> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename to IOptionsFactory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix for GH-262
Renaming to new groupId / artifactId / packages to ignore any future changes of maven / jaxb versions (preparing the v3 jakarta migration).
As pointed in the other PR, I think starting from 2.X version, this repo should be renamed to jaxb-tools and get merged with jaxb_basics and jaxb_annotate (and any other "plugins" that are commonly used by users of this jaxb-maven-plugin).
Also jaxb_basics has some PR waiting (dependencies updates for security fixes) that could be merged in before merged in this new mainstream repo.