Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to jakarta JAXB3 API and update some dependencies #165

Closed

Conversation

laurentschoelens
Copy link
Collaborator

I've been looking for the highsource jaxb2-basics project for the jaxb3 / jakarta migration but didn't find it, so here is my pull request for this feature.

Tested successfully on my own project.

Build passes with -Pall profile.
Feel free to look and merge.

@laurentschoelens
Copy link
Collaborator Author

I've by design decided to change the artifact / groupId and also package names to jaxb3 to avoid conflicts with the existing jaxb2 lib.

@laurentschoelens
Copy link
Collaborator Author

I'd also like to change the unofficial jaxb3 generator to use https://github.com/highsource/maven-jaxb2-plugin "official" highsource plugin with jaxb3 support (providing a pull request on this project too soon, if I can)

@Daemorinumi
Copy link

yes it could be usefull.

@laurentschoelens
Copy link
Collaborator Author

Made migration back to highsource jaxb-maven-plugin and updated some errors on build (cxf).
Need jdk11 to build (due to cxf 4 baseline to jdk11) but compatible with jdk8

@evantoli
Copy link

evantoli commented Mar 6, 2023

Thanks @laurentschoelens for raising this PR – we use this plugin extensively and are switching to the Jakarta namespace and package names.

Hi @highsource – is there only plan to move forward with this PR? At the moment we are building our own forked version using @laurentschoelens code.

But of course, we'd like to move back to using this standard plugin – either jaxb2-basics or as this PR suggests jaxb3-basics – whichever will support the Jakarta namespaces and packages.

@laurentschoelens
Copy link
Collaborator Author

Thanks for your comment @evantoli

I'm not sure that @highsource still there (seen some comments that suggets so).

@mattrpav : I've seen that you take this project back as maintainer, could you give us some feedback about this PR and the other one made in maven-jaxb2-plugin highsource/jaxb-tools#255 that it relies on.

@Stephan202
Copy link

I'm not sure that @highsource still there (seen some comments that suggets so).

Indeed, @highsource passed away; see #134. 😢

@laurentschoelens
Copy link
Collaborator Author

I'm not sure that @highsource still there (seen some comments that suggets so).

Indeed, @highsource passed away; see #134. 😢

That was the kind of comments I've seen 😢

@evantoli
Copy link

evantoli commented Mar 7, 2023

Thanks @laurentschoelens and @Stephan202 for the update.

Also thanks @mattrpav for providing an update in #134 and including the message from his wife with the link to his memorial page with many beautiful remembrances.

Also, @mattrpav, if there is something we can do to help with the @laurentschoelens PR please let us know.

I am partway through reviewing the PR and aside from some new files (which may simply be renamed files) it seems that all other changes are related to renaming Jaxb2 to Jaxb3 – which I also think is a good idea.

@mattrpav
Copy link
Collaborator

mattrpav commented Mar 7, 2023

@evantoli @laurentschoelens I'm checking in. I'm hoping to get into the jakarta support here shortly. I also need this in ActiveMQ for jakarta support over there as well.

@laurentschoelens
Copy link
Collaborator Author

Sorry to add more work on this PR but I've been working on #160 to end the work (initial commit contains jaxb2-fluent-api and jaxb2-value-constructor plugin migration)

@@ -311,7 +301,7 @@
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>1.9.3</version>
<version>1.9.4</version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treat #161

@laurentschoelens
Copy link
Collaborator Author

I've also reverted the deletion of distributionManagement section in parent pom :)

@cachescrubber
Copy link

Hi @laurentschoelens thanks for your effort. Do I understand you correctly, your MR also covers the other plugins (commons-lang, value-constructor, fluent-api, ...). Let me know If I can support you and @mattrpav to get this released.

@laurentschoelens
Copy link
Collaborator Author

laurentschoelens commented Mar 19, 2023

Hi @laurentschoelens thanks for your effort. Do I understand you correctly, your MR also covers the other plugins (commons-lang, value-constructor, fluent-api, ...). Let me know If I can support you and @mattrpav to get this released.

Hi @cachescrubber you got it right, my PR covers your issue by adding all remaining jaxb commons plugins. Please let me know if you have any issues.

@laurentschoelens
Copy link
Collaborator Author

@mattrpav thanks for trying to merge my PR
It's based on migrated maven-jaxb2-plugin with jakarta support to build

@mattrpav
Copy link
Collaborator

@laurentschoelens
Copy link
Collaborator Author

@laurentschoelens can you see about the build failure?

https://github.com/highsource/jaxb2-basics/actions/runs/4355967241/jobs/8079143601?pr=165

Yes, I've looked when notified.
Build failures due to use of unbuild jaxb3-maven-plugin in the other repository

@laurentschoelens
Copy link
Collaborator Author

@laurentschoelens can you see about the build failure?
https://github.com/highsource/jaxb2-basics/actions/runs/4355967241/jobs/8079143601?pr=165

Yes, I've looked when notified. Build failures due to use of unbuild jaxb3-maven-plugin in the other repository

See highsource/jaxb-tools#255

@laurentschoelens
Copy link
Collaborator Author

@mattrpav any news on this ?

@laurentschoelens
Copy link
Collaborator Author

Hello everyone
I know that you wait for this PR but it wont get to jaxb basics
Indeed, the project was migrated into jaxb-tools repository and upgrade is currently done for jaxb3 support on main branch.
Upgrade of dependencies was done too there and taking back older plugins also done.
You can also follow this migration guide to help users going through versions upgrade

@laurentschoelens
Copy link
Collaborator Author

Hello @Daemorinumi / @evantoli / @Stephan202 / @cachescrubber and everyone else looking for this PR.

V3 of jaxb-tools is released with first jakarta support of jaxb2-basics plugins

Feel free to look at the migration guide to get it work.

V4 will come shortly after, based on Jaxb v4 api / runtime.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants