feat: replace slugid with Buffer-less polyfill #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
force-pushed
the
manzt/slugid
branch
2 times, most recently
from
4be3b86
to
89f35e7
Compare
pkerpedjiev
reviewed
Aug 30, 2022
| @@ -101,14 +101,6 @@ export default defineConfig({ | |||
| return assetInfo.name; | |||
| } | |||
| }, | |||
| plugins: [ | |||
There was a problem hiding this comment.
Less config makes me happy!
pkerpedjiev
reviewed
Aug 30, 2022
|
|
||
| /** | ||
| * | ||
| * Returns a randomly generated uuid v4 compliant slug which conforms to a set |
There was a problem hiding this comment.
Did you code this yourself?
Any intention to send this to the slugid folks to see if they'll include it in their repo and get rid of the Buffer requirement?
There was a problem hiding this comment.
I did code this myself, yes. I just adapted some of their code, mostly.
I'd probably be able to make a PR, but right now the uuid library I chose @lukeed/uuid is fast but not cryptographically secure. A PR would probably entail refactoring internals with uuid as suggested taskcluster/slugid#12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aliases
slugidimport with a local./app/bufferless-slugid.jswhich does not rely onBufferglobal.Reliance on
Buffercomplicates the Vite build and adds additional bloat to higlass which isn't necessary.Fixes #___
Checklist