Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Funding %" field to Fund Code model #354

Closed
andrewtpham opened this issue Mar 28, 2020 · 1 comment · Fixed by #445
Closed

Add "Funding %" field to Fund Code model #354

andrewtpham opened this issue Mar 28, 2020 · 1 comment · Fixed by #445
Assignees
@calixo888
Labels
2 Simple issue requiring little effort enhancement New feature or request good first issue Good for newcomers
Milestone
Sprint 33

Comments

@andrewtpham
Copy link
Member

Is your feature request related to a problem? Please describe.
When users add a fund code to a program that means it is typically a percentage that is funding the program. It would be a nice to have to add the ability to track the % that this fund code is contributing to the total funding of the program.

For example 2 fund codes are linked to Program A: Fund code 1=75% and Fund code 2=25%.

Acceptance Criteria
A clear and concise description of how to ensure the feature request is met.

GIVEN I am a logged in user

AND I navigate a Program and click on the `Funding` tab

AND I should be able to click on `+ Fund Code` button to add a new Fund Code

THEN on this create modal, I should see a new input field (type=integer) under the Fund Code field where I can add a % that this fund code contributes to this program.

Additional context
image
@andrewtpham andrewtpham added enhancement New feature or request good first issue Good for newcomers 2 Simple issue requiring little effort labels Mar 28, 2020
@calixo888 calixo888 self-assigned this Apr 6, 2020
@andrewtpham andrewtpham added this to the Sprint 33 milestone Apr 6, 2020
@calixo888 calixo888 mentioned this issue Apr 8, 2020
Merged
@calixo888 calixo888 linked a pull request Apr 8, 2020 that will close this issue
ACT #354: Add "Funding %" field to Fund Code model #445
Merged
andrewtpham added a commit that referenced this issue Apr 13, 2020
@calixo888 @Kimaiyo077 @andrewtpham
ACT #354: Add "Funding %" field to Fund Code model (#445)
586a0f4 
* fixed hikaya 404 link - now linking to hikaya homepage

* minor changes

* refactoring and failure of transforming modal trigger to vuejs

* migrated customdashbaord admin models to admin.py

* migrated configurabledashboard admin models to admin.py

* deleted footer links

* removed programLinksAdmin model

* added funding input group

* added new field to fund code modal, and added field validation

* changed fund code model to 'percentage_of_funding' and changed the labels and placeholders

* added null=True to fund code model

* committed model changes

* merged migrations

Co-authored-by: Isaac Kimaiyo <40719885+Kimaiyo077@users.noreply.github.com>
Co-authored-by: Andrew <andrew.tc.pham@gmail.com>
@amosnjoroge
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calixo888 calixo888

Labels
2 Simple issue requiring little effort enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Sprint 33
Development

Successfully merging a pull request may close this issue.

ACT #354: Add "Funding %" field to Fund Code model hikaya-io/activity
3 participants
@andrewtpham @amosnjoroge @calixo888