Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACT-666 Re-implement Documents using Vue: Create modal #311

Closed
ninetteadhikari opened this issue Mar 14, 2020 · 3 comments · Fixed by #446
Closed

ACT-666 Re-implement Documents using Vue: Create modal #311

ninetteadhikari opened this issue Mar 14, 2020 · 3 comments · Fixed by #446
Assignees
@chelliah
Labels
2 Simple issue requiring little effort good first issue Good for newcomers refactor Time to restructure some code!
Milestone
Sprint 33

Comments

@ninetteadhikari
Copy link
Member

ninetteadhikari commented Mar 14, 2020 •
edited by andrewtpham
Loading

Is your feature request related to a problem? Please describe.
This is not related to a problem.
Jira ticket: ACT-666

Acceptance Criteria

GIVEN 
I am a logged in user

WHEN
- I go to the Components > Documents page 
- I click on the '+ Documents' button

THEN 
- I will see a modal window to add a new Documents

Additional context
Currently the feature is generated with Django templates using JQuery and this ticket is to render it using Vue.
Example PR as reference for changing Levels and Indicator Type to Vue: #239
Example #2: #345

image
@ninetteadhikari ninetteadhikari added enhancement New feature or request good first issue Good for newcomers 2 Simple issue requiring little effort labels Mar 14, 2020
@andrewtpham
Copy link
Member

Hey @chelliah would you be interested in taking on this card?

@chelliah
Copy link
Contributor

chelliah commented Apr 7, 2020

yes this sounds great! I'll work on this and then try to tackle some of the other vue conversion tickets once I'm done

@andrewtpham andrewtpham linked a pull request Apr 9, 2020 that will close this issue
ACT-666 Re-implement Documents using Vue: Create modal #446
Merged
@andrewtpham andrewtpham added this to the Sprint 33 milestone Apr 9, 2020
@andrewtpham andrewtpham added refactor Time to restructure some code! and removed enhancement New feature or request labels Apr 9, 2020
@amosnjoroge
Copy link
Collaborator

implemented
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chelliah chelliah

Labels
2 Simple issue requiring little effort good first issue Good for newcomers refactor Time to restructure some code!
Projects
None yet
Milestone
Sprint 33
Development

Successfully merging a pull request may close this issue.

ACT-666 Re-implement Documents using Vue: Create modal hikaya-io/activity
4 participants
@andrewtpham @chelliah @ninetteadhikari @amosnjoroge