-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACT-666 Re-implement Documents using Vue: Create modal #446
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #446 +/- ##
=======================================
Coverage 50.60% 50.60%
=======================================
Files 110 110
Lines 8359 8359
=======================================
Hits 4230 4230
Misses 4129 4129
Continue to review full report at Codecov.
|
@chelliah , Nice work on implementing the add document modal with Vue. Your work looks great but I had a few observations. One is, there seems to be an error that pops up before the component is mounted. Could you look into why this is happening? That error means that I cannot get Programs to populate the options in the modal itself even though I have existing programs in my organization. Please look into these two issues so I can be able to test whether I create a new document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if the ticket is only for Document creation 👍
Just address @Kimaiyo077 request
Thanks @Kimaiyo077! I'll take a look at that loading error and let you know |
Latest comment from @chelliah:
@Kimaiyo077 is there any support you can provide on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chelliah This is working from my end 😊 🧁
@Kimaiyo077 I couldn't reproduce your issue :( shall we merge this?
What is the Purpose?
This PR reimplements the 'Add new document' modal using the Vue.js vue_modal component
What was the approach?
I used the 'indicator_list.html' and 'add_indicator_modal.html' as the base model and copied the same logic into the documents_list file
Are there any concerns to addressed further before or after merging this PR?
What would the next steps be? I could implement document deletion, or move the rest of the documention_list page to vue.
Mentions?
Mention persons you'd like to review this PR
Issue(s) affected?
(https://github.com/hikaya-io/activity/issues/311)