-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACT-692: Add config for staging cluster #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darius-Ndubi
force-pushed
the
ACT-692
branch
4 times, most recently
from
March 30, 2020 09:23
47bd719
to
b3b31f2
Compare
Codecov Report
@@ Coverage Diff @@
## dev #360 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 62 62
Lines 2640 2640
=======================================
Hits 1914 1914
Misses 726 726 Continue to review full report at Codecov.
|
Darius-Ndubi
force-pushed
the
ACT-692
branch
14 times, most recently
from
March 31, 2020 09:09
20727c2
to
acb08df
Compare
Darius-Ndubi
changed the title
ACT-692: [WIP] Add config for staging cluster
ACT-692: Add config for staging cluster
Mar 31, 2020
Darius-Ndubi
changed the title
ACT-692: Add config for staging cluster
ACT-692:[WIP] Add config for staging cluster
Mar 31, 2020
Darius-Ndubi
force-pushed
the
ACT-692
branch
2 times, most recently
from
April 3, 2020 09:40
8616e40
to
e96d39e
Compare
odenypeter
previously approved these changes
Apr 3, 2020
Darius-Ndubi
force-pushed
the
ACT-692
branch
5 times, most recently
from
April 3, 2020 17:25
9580b33
to
3c593be
Compare
Darius-Ndubi
changed the title
ACT-692:[WIP] Add config for staging cluster
ACT-692: Add config for staging cluster
Apr 3, 2020
Darius-Ndubi
force-pushed
the
ACT-692
branch
3 times, most recently
from
April 3, 2020 21:19
2910c0c
to
9010efa
Compare
Add config to create staging image Add config to deploy to staging custer
odenypeter
approved these changes
Apr 6, 2020
Darius-Ndubi
added a commit
that referenced
this pull request
Apr 6, 2020
Add config to create staging image Add config to deploy to staging custer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Add config to create staging image
Add config to deploy to staging cluster
What was the approach?
Adds conditionals to deploy on branch staging
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@andrewtpham
@nasirhjafri
@odenypeter
Issue(s) affected?
None