Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACT-692: Add config for staging cluster #360

Merged
merged 1 commit into from
Apr 6, 2020
Merged

ACT-692: Add config for staging cluster #360

merged 1 commit into from
Apr 6, 2020

Conversation

Darius-Ndubi
Copy link
Contributor

@Darius-Ndubi Darius-Ndubi commented Mar 30, 2020

What is the Purpose?
Add config to create staging image
Add config to deploy to staging cluster

What was the approach?

Adds conditionals to deploy on branch staging

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham
@nasirhjafri
@odenypeter

Issue(s) affected?

None

@Darius-Ndubi Darius-Ndubi force-pushed the ACT-692 branch 4 times, most recently from 47bd719 to b3b31f2 Compare March 30, 2020 09:23
@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #360 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #360   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          62       62           
  Lines        2640     2640           
=======================================
  Hits         1914     1914           
  Misses        726      726           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64773d...2775794. Read the comment docs.

@Darius-Ndubi Darius-Ndubi force-pushed the ACT-692 branch 14 times, most recently from 20727c2 to acb08df Compare March 31, 2020 09:09
@Darius-Ndubi Darius-Ndubi changed the title ACT-692: [WIP] Add config for staging cluster ACT-692: Add config for staging cluster Mar 31, 2020
@Darius-Ndubi Darius-Ndubi changed the title ACT-692: Add config for staging cluster ACT-692:[WIP] Add config for staging cluster Mar 31, 2020
@Darius-Ndubi Darius-Ndubi force-pushed the ACT-692 branch 2 times, most recently from 8616e40 to e96d39e Compare April 3, 2020 09:40
odenypeter
odenypeter previously approved these changes Apr 3, 2020
@Darius-Ndubi Darius-Ndubi force-pushed the ACT-692 branch 5 times, most recently from 9580b33 to 3c593be Compare April 3, 2020 17:25
@Darius-Ndubi Darius-Ndubi changed the title ACT-692:[WIP] Add config for staging cluster ACT-692: Add config for staging cluster Apr 3, 2020
@Darius-Ndubi Darius-Ndubi force-pushed the ACT-692 branch 3 times, most recently from 2910c0c to 9010efa Compare April 3, 2020 21:19
Add config to create staging image
Add config to deploy to staging custer
@odenypeter odenypeter merged commit 31c9324 into dev Apr 6, 2020
@odenypeter odenypeter deleted the ACT-692 branch April 6, 2020 10:45
Darius-Ndubi added a commit that referenced this pull request Apr 6, 2020
Add config to create staging image
Add config to deploy to staging custer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACT-692 Ability to automatically deploy from 'dev" to "staging" when a PR is merged
3 participants