Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves footer to bottom #377

Merged
merged 5 commits into from
Apr 5, 2020
Merged

Moves footer to bottom #377

merged 5 commits into from
Apr 5, 2020

Conversation

ninetteadhikari
Copy link
Member

What is the Purpose?

Moves the footer to the bottom of the contact table

What was the approach?

Moved the endblock content to the to the bottom of the contact_list file

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@Kimaiyo077 @andrewtpham

Issue(s) affected?

None

@codecov-io
Copy link

codecov-io commented Apr 4, 2020

Codecov Report

Merging #377 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #377   +/-   ##
=======================================
  Coverage   50.28%   50.28%           
=======================================
  Files          98       98           
  Lines        8304     8304           
=======================================
  Hits         4176     4176           
  Misses       4128     4128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e361e82...aa1872e. Read the comment docs.

@andrewtpham andrewtpham merged commit 3f6ecd6 into dev Apr 5, 2020
@andrewtpham andrewtpham deleted the contact-footer branch April 5, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants