Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACT-406: Create fixtures for Country and Sector data as global picklist in all environments #458

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

Kimaiyo077
Copy link
Collaborator

What is the Purpose?

Add default global data for Activity that will be used across all environments.

What was the approach?

  • Update Country model's description field to accept a value of null
  • Get all default data that is needed and add them to fixtures.

Are there any concerns to addressed further before or after merging this PR?

The country and sector models in your database should not have any existing data.

Mentions?

@odenypeter @nasirhjafri @TAnas0

Issue(s) affected?

#399

Copy link
Collaborator

@TAnas0 TAnas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Countries fixtures is exhaustive and tests have been adapted to the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACT-406 Create fixtures for Country and Sector data as global picklist in all environments
2 participants