Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging with fix for indicator delete #499

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Update staging with fix for indicator delete #499

merged 1 commit into from
Apr 28, 2020

Conversation

Kimaiyo077
Copy link
Collaborator

What is the Purpose?

Update staging with the fix for indicator delete that is on dev

What was the approach?

Update staging with the fix for indicator delete that is on dev

Are there any concerns to addressed further before or after merging this PR?

This PR should not be squashed but rather use the normal merge so that commits on dev and staging are aligned

Mentions?

@sannleen @andrewtpham

Issue(s) affected?

List of issues addressed by this PR.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #499 into staging will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #499      +/-   ##
===========================================
- Coverage    50.67%   50.65%   -0.02%     
===========================================
  Files          111      111              
  Lines         8423     8427       +4     
===========================================
+ Hits          4268     4269       +1     
- Misses        4155     4158       +3     
Impacted Files Coverage Δ
indicators/urls.py 100.00% <ø> (ø)
indicators/views.py 19.28% <25.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f9c5b...9c71d6f. Read the comment docs.

@Kimaiyo077 Kimaiyo077 merged commit 38e5cbd into staging Apr 28, 2020
@hikaya-io hikaya-io locked and limited conversation to collaborators May 4, 2020
@hikaya-io hikaya-io unlocked this conversation May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants