Make it work on node18, fix node19 separately

hildjj · Nov 29, 2022 · eabcb09 · eabcb09
1 parent 333da67
commit eabcb09
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14, 16, 18, 19]
+        node-version: [14, 16, 18]
         platform: [ubuntu-latest]
 
     runs-on: ${{ matrix.platform }}

diff --git a/test/index.ava.js b/test/index.ava.js
@@ -57,9 +57,16 @@ test('explicit cert and ca', async t => {
   })
   s.listen()
   await pEvent(s, 'listening')
-  const cli = connect(s.port)
+  // Extra steps to ensure node 18 doesn't deadlock.
+  let res = null
+  const connected = new Promise(resolve => {
+    res = resolve
+  })
+  const cli = connect(s.port, res)
+  await connected
+  const close = pEvent(cli, 'close')
   cli.end()
-  await pEvent(cli, 'close')
+  await close
   s.close()
   t.pass()
 })