Hooks api #103
Hooks api #103
Conversation
|
I'll check this after merging #102. 👍 |
| # Send 'DELETE a hook for a repository' request | ||
| # @see https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Busername%7D/%7Brepo_slug%7D/hooks/%7Buid%7D#delete | ||
| # | ||
| # @param options [Hash] The attributes to update |
There was a problem hiding this comment.
I think that this comment should be fixed. 🤔
| # | ||
| # @param options [Hash] The attributes to update | ||
| # @return [Tinybucket::Model::Hook] | ||
| def update(hook, options = {}) |
There was a problem hiding this comment.
This method require hook param comment just like here.
| # | ||
| # @param options [Hash] The attributes to update | ||
| # @return [Boolean] | ||
| def delete(hook, options = {}) |
There was a problem hiding this comment.
This method require hook param comment just like here.
lib/tinybucket/resource/hooks.rb
Outdated
| # @param branch [String] | ||
| # @param options [Hash] | ||
| # @return [Tinybucket::Model::Hook] | ||
| def find(branch, options = {}) |
There was a problem hiding this comment.
According this code, I think that branch argument should be renamed to hook. 🤔
|
Pushed updates regarding your comments. Feel free to review whenever you can |
|
I created a script to test each hooks API with real test repository on Bitbucket. And I found these points. (1) Bitbucket pipeline webhook can fetch via
|
|
This looks like a bitbucket issue. in the past i managed to avoid these errors by explicitly setting the |
No description provided.