Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 fix "bundle install error" #120

Merged
merged 1 commit into from
Feb 12, 2017
Merged

💄 fix "bundle install error" #120

merged 1 commit into from
Feb 12, 2017

Conversation

hirakiuc
Copy link
Owner

@hirakiuc hirakiuc commented Feb 12, 2017 •
edited
Loading

In #118, I exclude unnecessary files in gem package.

But this code depends on rake and this cause error on executing newly bundle install.

By this pull request, I use Dir.glob to create the same file list.

@hirakiuc hirakiuc added the bug label Feb 12, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.888% when pulling 1d9572a on dont_use_rake_in_gemspec into cdfc1f5 on master.

@hirakiuc
Copy link
Owner Author

LGTM. 😃

@hirakiuc hirakiuc merged commit b40d711 into master Feb 12, 2017
@hirakiuc hirakiuc deleted the dont_use_rake_in_gemspec branch February 12, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirakiuc @coveralls