Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unclear licensed fixedsys font #9

Closed
wants to merge 1 commit into from

Conversation

falkTX
Copy link

@falkTX falkTX commented Feb 25, 2022

The "fixedsys.ttf" font file does not have a clear license, seems a very old font that got some used by microsoft at some point.
But I couldn't find details on allowed uses, redistribution, derivatives, etc.
As such, it is unsuitable for use in a GPL licensed project.
It also complicates packaging.

This font is never used in the code though, as the C++ classes that reference it are defined but never used.
So I replaced it with the monospaced font provided by VCV Rack, just so it still works in case these classes are later on used in some new modules.

@hires
Copy link
Owner

hires commented Feb 25, 2022

It's some old font I found somewhere and I use it in some other plugins that use the same libs. I'm pretty sure it's so generic that nobody is going to care about it, especially if it's not used in this project.

@hires hires closed this Feb 25, 2022
@falkTX

This comment was marked as outdated.

@dromer

This comment was marked as outdated.

@hires

This comment was marked as outdated.

@falkTX

This comment was marked as outdated.

@hires

This comment was marked as outdated.

@hires hires reopened this Feb 25, 2022
@dromer

This comment was marked as outdated.

@hires

This comment was marked as outdated.

@falkTX

This comment was marked as outdated.

@hires

This comment was marked as outdated.

@falkTX

This comment was marked as outdated.

@falkTX

This comment was marked as outdated.

@dromer

This comment was marked as outdated.

@falkTX

This comment was marked as outdated.

@dromer

This comment was marked as outdated.

Signed-off-by: falkTX <falktx@falktx.com>
@falkTX

This comment was marked as outdated.

@hires
Copy link
Owner

hires commented Jun 16, 2022

I have found and replaced fixedsys.ttf with one that has an open license and added info about it in an accompanying file.

@hires hires closed this Jun 16, 2022
@dromer
Copy link

dromer commented Jun 16, 2022

Why did you rename the new font to the old (proprietary) name? this will likely just confuse anyone using the project.

@hires
Copy link
Owner

hires commented Jun 16, 2022

Why did you rename the new font to the old (proprietary) name? this will likely just confuse anyone using the project.

Many of my plugins use the original file so I wanted to modify it "upstream" as it were. The accompanying text file explains the origin of the file so there shouldn't be any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants