Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make predicate status timestamps optional #425

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

MicaiahReid
Copy link
Contributor

Description

This changes the predicate status timestamps:

  • from String (converted from a u128) to a u64
    • this means we are now storing the data in seconds rather than milliseconds
  • makes them optional (so they will not appear in a serialized status if set to None)

Breaking change?

Previously the timestamp was in milliseconds, now it's in seconds. Anyone depending on the timestamp being in milliseconds could be impacted by this change.


Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MicaiahReid!

@MicaiahReid MicaiahReid merged commit 10d6475 into develop Oct 4, 2023
1 check passed
@MicaiahReid MicaiahReid deleted the optional-timestamp branch October 4, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants