Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate error when storing peer_info #682

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

csgui
Copy link
Contributor

@csgui csgui commented Nov 6, 2024

Adds error propagation when trying to insert peer_info data.

@csgui csgui force-pushed the chore/warn_mock_proposals branch 2 times, most recently from 6616145 to c7d14ca Compare November 6, 2024 16:57
@csgui csgui requested review from rafaelcr and zone117x November 6, 2024 16:58
@rafaelcr
Copy link
Collaborator

rafaelcr commented Nov 6, 2024

I was able to look at this briefly and I strongly suspect the problem is that we're being unable to write some of the block_proposal peer info data to the DB in the first place. This is why predicate evaluations fail when trying to retrieve those signer messages from the DB. @zone117x did you see any unable to write mock proposal log messages in your tests?

I noticed the problem could lie here, where we're not propagating a possible write error to the caller so we never notice the peer info wasn't written to the DB. (Oops, my bad)

@csgui could you add a ? at the end of that statement and debug that before trying to silence these read errors? We might be able to fix the root of this problem. The PR as it stands right now will only mask the problem.

@csgui csgui force-pushed the chore/warn_mock_proposals branch from c7d14ca to 1bc949a Compare November 6, 2024 18:13
@csgui csgui changed the title warn when not able to query mock_proposals table propagate error when storing peer_info Nov 6, 2024
@csgui
Copy link
Contributor Author

csgui commented Nov 6, 2024

@rafaelcr Thanks for the swift reply! Added the error propagation.

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csgui ! We should try this out in mainnet and I'm pretty sure the DB write error will stick out pretty quickly

@csgui csgui had a problem deploying to Development-mainnet November 6, 2024 18:43 — with GitHub Actions Failure
@csgui csgui had a problem deploying to Development-testnet November 6, 2024 18:43 — with GitHub Actions Failure
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csgui!

@csgui csgui merged commit cb5a7c3 into stacks-signers Nov 7, 2024
10 of 12 checks passed
@csgui csgui deleted the chore/warn_mock_proposals branch November 7, 2024 15:05
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 1.9.0-stacks-signers.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants