Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributors-guide.md #462

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

Scofield-Idehen
Copy link
Contributor

Work on simple grammar and place holder correction, simplified the terms and made it easer for the readers to grasp the meaning

Description

Describe the changes that were made in this pull request. When possible start with the motivations behind the change. Be sure to also include the following information:

  1. Motivation for change?
  2. What was changed?
  3. Link to relevant issues?

Checklist

  • Conventional commits were used
  • New links to files and images were verified
  • For fixes/refactors: all existing references were identified and replaced
  • Style guide was reviewed and applied
  • Clear code samples were provided
  • People were tagged for review

Work on simple grammar and place holder correction, simplified the terms and made it easer for the readers to grasp the meaning
@netlify
Copy link

netlify bot commented Sep 3, 2023

👷 Deploy request for docs-hiro pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3c7b314

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 10:21pm

@hugocaillard
Copy link
Collaborator

Thanks for your contribution @Scofield-Idehen
The change look good to me.
But this page is orphan (not available in the side or from the footer). So I wonder if we want to keep it.

cc @mefrem

@hugocaillard hugocaillard requested a review from mefrem October 4, 2023 13:48

This guide describes how to contribute to Hiro documentation and content so feedback is received. Hiro can then incorporate these comments to improve the overall developer documentation experience.
This guide describes how to contribute to Hiro's documentation and content so feedback is received. Hiro can then incorporate these comments to improve the overall developer documentation experience.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be ideal to delete these two paragraphs as they are unnecessary preamble.

Copy link
Contributor

@mefrem mefrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a note, and otherwise LGTM!

@mefrem mefrem merged commit 2cb7f72 into hirosystems:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants