Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update stacks.js pages #616

Merged
merged 7 commits into from
Feb 26, 2024
Merged

docs: update stacks.js pages #616

merged 7 commits into from
Feb 26, 2024

Conversation

janniks
Copy link
Contributor

@janniks janniks commented Feb 12, 2024

  • updates to Stacks.js pages
  • adds code tabs, will add more of these (e.g. npm VS yarn; stacks.js VS connect)
  • removes legacy pages

@janniks janniks requested a review from ryanwaits February 12, 2024 16:44
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 1:34pm

Copy link
Collaborator

@ryanwaits ryanwaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! minor detail, but the code blocks inside of the new tabs are a bit smaller than the other code blocks, not a blocking issue (no pun intended)

@ryanwaits
Copy link
Collaborator

Reference: Screenshot 2024-02-23 at 11 04 15 AM

@janniks
Copy link
Contributor Author

janniks commented Feb 23, 2024

Ah, thx. Updated the rule to only target the tabs (header), what I had intended ^^

@janniks janniks merged commit 5e6c87c into main Feb 26, 2024
5 checks passed
@janniks janniks deleted the docs/update-stacksjs branch February 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants