Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new clarinet sdk guides #754

Merged
merged 11 commits into from
Sep 25, 2024
Merged

new clarinet sdk guides #754

merged 11 commits into from
Sep 25, 2024

Conversation

ryanwaits
Copy link
Collaborator

@ryanwaits ryanwaits commented Sep 20, 2024

What does this PR do?

Add two testing guides for the Clarinet SDK:

  • Update the unit testing guide
  • Add new integration testing guide

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 5:07pm

@ryanwaits ryanwaits changed the title initial commit for integration testing guide new clarinet sdk guides Sep 20, 2024
@ryanwaits ryanwaits self-assigned this Sep 20, 2024
made a few grammar tweaks
Made some grammar tweaks
capitalization tweak
capitalization tweak
Copy link
Contributor

@max-crawford max-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adding my Slack note here for posterity:

One question that these guides bring to mind for me is that both are guides that walk through a specific example, but what both guides lack is any guidance around best practices for tests outside of that specific use case.

Would that be valuable to other devs?

Framed another way, when I finished reading that, I was like "ok I have some idea of how that test was done, but I'm not sure if I have the knowledge/framework to apply those tests to my own project"

@ryanwaits ryanwaits merged commit 61f03fa into main Sep 25, 2024
4 checks passed
@ryanwaits ryanwaits deleted the feat/integration-test-guide branch September 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants