Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api updates #761

Merged
merged 7 commits into from
Oct 1, 2024
Merged

api updates #761

merged 7 commits into from
Oct 1, 2024

Conversation

ryanwaits
Copy link
Collaborator

@ryanwaits ryanwaits commented Sep 27, 2024

What does this PR do?

Updates several outdated examples and information in API References

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:16pm

@ryanwaits ryanwaits marked this pull request as ready for review October 1, 2024 02:04
@ryanwaits ryanwaits requested a review from ECBSJ October 1, 2024 02:04
@ryanwaits
Copy link
Collaborator Author

ryanwaits commented Oct 1, 2024

@diwakergupta I remember the decision from a few months back to stop maintaining v2 endpoints and im seeing this reflected in the updated OpenAPI spec.

We still have several v2 endpoints documented (from before we stopped maintaining), and since any subsequent requests to our spec won't bring in any v2 endpoints, I'm leaning toward removing the existing endpoints we have up now and reference the RPC endpoints, re: #780

Let me know what you think.

Copy link
Member

@diwakergupta diwakergupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also have @zone117x take a look

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Diwaker's comments.

I also left a comment regarding the RPC endpoints in the referenced issue #780 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants