fix: randomize key order for testnet stx faucet transactions #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Vercel deployment URL: https://stacks-blockchain-qz5c5wiuw-hirosystems.vercel.app 🚀 |
CharlieC3
reviewed
Oct 15, 2024
| if (fee) options.fee = fee; | ||
|
|
||
| // Detect possible custom network chain ID | ||
| network.chainId = await fetchNetworkChainID(network); |
There was a problem hiding this comment.
It could, but there are ways to deploy the API without setting that env var (SKIP_STACKS_CHAIN_ID_CHECK=bool was added a while back). I don't really have a strong opinion on what to use here.
|
🎉 This PR is included in version 8.1.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 16, 2024
## [8.1.0](v8.0.4...v8.1.0) (2024-10-16) ### Features * add block etag ([#2103](#2103)) ([66e6800](66e6800)) * add cache handler for principal activity including mempool transactions ([#2100](#2100)) ([2370c21](2370c21)) * add principal cache etag to account endpoints ([#2097](#2097)) ([28e9864](28e9864)) * return estimated balance in account balance endpoints ([#2104](#2104)) ([e217cea](e217cea)) ### Bug Fixes * add declaration copy step in build ([#2110](#2110)) ([2b6aa6a](2b6aa6a)) * prune and restore mempool transactions with equal nonces for the same sender ([#2091](#2091)) ([1ce75de](1ce75de)) * randomize key order for testnet stx faucet transactions ([#2120](#2120)) ([f7265f9](f7265f9)) * update mempool garbage collection logic for 3.0 ([#2117](#2117)) ([8b10b69](8b10b69)) * use total_count CTE and return it with the parsed results ([#2073](#2073)) ([bb30911](bb30911))
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few fixes to the testnet STX faucet:
TestnetNetworks with theSTACKS_FAUCET_NODE_HOSTandSTACKS_FAUCET_NODE_PORTvalues from .env plus the standard testnet network, these ENV vars are now treated only as override values. This fixes an issue where both pairs of values essentially pointed to the same network nodes causing faucet transactions to be duplicated in certain scenarios.