Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(rosetta): Nakamoto timestamps #2132

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

zone117x
Copy link
Member

Closes #2131

In Rosetta block responses, the timestamp field uses Nakamoto block times in epoch3 (now that they are consensus-level / reliable).

In epoch2.x, the burn-block-time is still used.

@zone117x zone117x changed the title Fix/rosetta nakamoto timestamps Fix(rosetta): Nakamoto timestamps Oct 21, 2024
@zone117x zone117x requested a review from rafaelcr October 21, 2024 11:18
Copy link

github-actions bot commented Oct 21, 2024

Vercel deployment URL: https://stacks-blockchain-6yo7ig8t6-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zone117x zone117x force-pushed the fix/rosetta-nakamoto-timestamps branch from c29af17 to 36cfe2e Compare October 21, 2024 11:19
@zone117x zone117x linked an issue Oct 21, 2024 that may be closed by this pull request
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone117x zone117x merged commit bd13962 into master Oct 21, 2024
27 checks passed
@zone117x zone117x deleted the fix/rosetta-nakamoto-timestamps branch October 21, 2024 13:45
blockstack-devops pushed a commit that referenced this pull request Oct 21, 2024
## [8.1.2](v8.1.1...v8.1.2) (2024-10-21)

### Bug Fixes

* **rosetta:** support tenure change transactions ([#2128](#2128)) ([bfbf65c](bfbf65c))
* **rosetta:** use Nakamoto block timestamps for epoch3/Nakamoto block responses ([#2132](#2132)) ([bd13962](bd13962))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rosetta: use Nakamoto block timestamp
3 participants