-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: event-replay block parsing outdated and incorrect #2133
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Vercel deployment URL: https://stacks-blockchain-hvppvv6qd-hirosystems.vercel.app 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
## [8.2.0-beta.1](v8.1.2...v8.2.0-beta.1) (2024-10-23) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
🎉 This PR is included in version 8.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.2.0](v8.1.2...v8.2.0) (2024-10-25) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.2.0-beta.1](v8.1.2...v8.2.0-beta.1) (2024-12-17) ### Features * adjust rBTC default amount, add xlarge url param, add tests ([b30f16a](b30f16a)) * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * change tbtc faucet default, allow user to request more than default ([8e3f288](8e3f288)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa)) * update BTC faucet comments to use regtest instead of testnet ([ced8242](ced8242))
The event-replay logic was using a copy&pasted function for parsing
/new_block
data, which had become outdated and incorrect.This removes the duplicated code, and both event-replay and regular block ingestion use the same (correct) block parsing code.