Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle properties is the common file to set support lib version. #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erdemolkun
Copy link

Android support library version changed in a single place.

@ablenesi
Copy link

Would this solution show lint warnings if a dependency should be updated?

@erdemolkun
Copy link
Author

@ablenesi Yes it shows after gradle sync.

accessToken = UNDEFINED

android_support_library_version = 23.3.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment! feel free to ignore.

What is the reason for changing property name from SUPPORT_LIBRARY_VERSION to android_support_library_version?
For consistency with other property name, should have used the same one.

@ablenesi
Copy link

There was no update on this for the last 3 years, @amardeshbd consider closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants