add Arduino build + English manual #62
Conversation
|
@amotl |
|
Dear Rob, wow, that was quick, and your patch is really extensive. Thank you so much! With kind regards, |
|
@amotl |
| platforms: | ||
| rpipico: | ||
| board: rp2040:rp2040:rpipico | ||
| package: rp2040:rp2040 | ||
| gcc: | ||
| features: | ||
| defines: | ||
| - ARDUINO_ARCH_RP2040 | ||
| warnings: | ||
| flags: | ||
|
|
||
| packages: | ||
| rp2040:rp2040: | ||
| url: https://github.com/earlephilhower/arduino-pico/releases/download/global/package_rp2040_index.json |
There was a problem hiding this comment.
I see that esp32 is selected down below. In this spirit, I am wondering why any references to the Pico are needed?
There was a problem hiding this comment.
These rpipico lines are not needed per se, however it would allow you to include it in a future test.
Pico is not supported directly in the core Arduino build.
This is what is needed to get the build working with an rpipico compiler.
| libraries: | ||
| - U8g2 | ||
| - HX711 | ||
| - ESP32Servo |
There was a problem hiding this comment.
Is it possible to apply version pinning here?
There was a problem hiding this comment.
Not that I know of, default it uses the latest versions as far as I know.
| - run: | | ||
| gem install arduino_ci | ||
| arduino_ci.rb |
There was a problem hiding this comment.
We can probably read up on it on the documentation of Arduino-CI, but let us also ask right here: What does invoking arduino_ci.rb actually do in this context? Does it even "run" the sketch to completion, and how?
On the Arduino-CI docs, I can find:
[...] provides a system of mocks that allow fine-grained control over the hardware inputs, including the system's clock
We can't imagine some set of standard mocks can satisfy the requirements of HaniMandl easily. What about the display interface, for example?
There was a problem hiding this comment.
We guess the current state "just compiles" the code, and verifies it on behalf of that outcome, just like platformio-ci.yaml is doing it, right?
Coming from there, do you have any suggestions how we could apply better unit testing to the codebase? I guess it would need to be tremendously modularized, in order to achieve that?
Apologies for our beginner's questions. Please do not spend too much time answering them, we are also writing them down for our own reference, in order to outline where we will need to level up on understanding and using Arduino-CI properly. The right way will be to do it hands-on, paired with reading relevant documentation sections. We just didn't get around doing it, yet.
There was a problem hiding this comment.
What does invoking arduino_ci.rb actually do in this context? Does it even "run" the sketch to completion, and how?
arduino_ci.rb is a ruby script that calls the command line Arduino compilers.
There was a problem hiding this comment.
We can't imagine some set of standard mocks can satisfy the requirements of HaniMandl easily. What about the display interface, for example?
Mocks are not too difficult, but takes quite some effort to implement, so I do not know if it is worth the effort.
Mocks are ideal for testing a part of a library, when you would create some core "hanimandl" library it might make sense to put the effort in. A way to do this is to split of typical functions in a separate hanimadl.h file and then you would be able to test these functions.
There was a problem hiding this comment.
We guess the current state "just compiles" the code, and verifies it on behalf of that outcome, just like platformio-ci.yaml is doing it, right?
That is right, however it does compile the code under the Arduino IDE, not under the PlatformIO environment. As these are different it adds "robustness". The same is true for doing the LINT check, it does look at the code and even if it compiles it warns you of some risky code constructs.
There was a problem hiding this comment.
Coming from there, do you have any suggestions how we could apply better unit testing to the codebase? I guess it would need to be tremendously modularized, in order to achieve that?
Yes, think so.
As said before, the first step is to extract some typical hanimandl functions.
I looked quickly at the code and I see you have organized it in a way that keeps all things close to each other, however many functions do handle pins, do display work and changes some setting etc. A program of this size I would split of all display handling in one file, all the reading of buttons (pin IO) in one file, the handling of rotary encoders in one file.
Furthermore I would have a STATE variable that defines the modus operandi of the program.
Am I in state_setup, state_filling or state_error, etc.
So yes, quite some work.
examples/hanimandl/hanimandl.ino
Outdated
There was a problem hiding this comment.
Is there a reason attached to this, that the code had to be duplicated into examples/hanimandl/hanimandl.ino?
There was a problem hiding this comment.
Ah right, you elaborated about this details over at #18 (comment):
Note that I use the Arduino-CI mainly for libraries, and I used it for an application by adding an "examples" folder, in which the applications are copied as if they were examples from a library. See - https://github.com/RobTillaart/MultiSpeedI2CScanner
Maybe it is applicable to use a symlink for that purpose?
There was a problem hiding this comment.
Is there a reason attached to this, that the code had to be duplicated into examples/hanimandl/hanimandl.ino?
As the Arduino build CI is originally developed for testing libraries, it is the trick to make it testing stand alone programs.
Maybe it is applicable to use a symlink for that purpose?
Good question, never tested,
There was a problem hiding this comment.
Maybe it is applicable to use a symlink for that purpose?
The build-CI VM runs ubuntu, my develop environment is windows, so the symlink semantics might differ.
Needs some investigation.
README.md
Outdated
| @@ -4,6 +4,8 @@ | |||
|  | |||
|  | |||
|
|
|||
| [](https://github.com/marketplace/actions/arduino_ci) | |||
There was a problem hiding this comment.
Just spotted a one-character typo.
| [](https://github.com/marketplace/actions/arduino_ci) | |
| [](https://github.com/marketplace/actions/arduino_ci) |
There was a problem hiding this comment.
Will fix that one right away.
|
I just ran through a quick review, yielding some comments shared above, and will be happy to try addressing all details on my own behalf before merging. When doing it, I will also squash your commits as suggested. Thanks again! |
|
Two things you could start using:
|
|
You might want to have this badge in the readme too? |
English manual by google translate and quickly reviewed by me. Needs verification.