Fix rounding error in depreciation value using decimal arithmetic #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This plugin currently converts start and end values from
Decimal
tofloat
before doing any calculations.float
is appropriate for generating the depreciation curves, but not for calculating the depreciation values that will go into the ledger. As a result, for many choices of start value, floating-point error causes this plugin to produce unbalanced transactions like the following:The fix is to keep the start and end values as
Decimal
s except when generating the depreciation curves.How was this patch tested?
Added an end-to-end test called
test_rounding_errors()
that previously failed and now passes.