Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddressType.cs #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AhmadKelany
Copy link

added PlotIdentification property to address type

added PlotIdentification property to address type
@hkutluay
Copy link
Owner

Thanks for your contribution.

But there is no property named as PlotIdentification on AddressType on UBL-CommonAggregateComponents-2.1.xsd Reference

@AhmadKelany could you please cite the reference that contains PlotIdentification on AddressType

<xsd:complexType name="AddressType">
		<xsd:sequence>
			<xsd:element ref="cbc:ID" minOccurs="0"/>
			<xsd:element ref="cbc:Postbox" minOccurs="0"/>
			<xsd:element ref="cbc:Room" minOccurs="0"/>
			<xsd:element ref="cbc:StreetName" minOccurs="0"/>
			<xsd:element ref="cbc:BlockName" minOccurs="0"/>
			<xsd:element ref="cbc:BuildingName" minOccurs="0"/>
			<xsd:element ref="cbc:BuildingNumber" minOccurs="0"/>
			<xsd:element ref="cbc:CitySubdivisionName"/>
			<xsd:element ref="cbc:CityName"/>
			<xsd:element ref="cbc:PostalZone" minOccurs="0"/>
			<xsd:element ref="cbc:Region" minOccurs="0"/>
			<xsd:element ref="cbc:District" minOccurs="0"/>
			<xsd:element ref="cac:Country"/>
		</xsd:sequence>
	</xsd:complexType>

@AhmadKelany
Copy link
Author

You're welcome Hakan.

In this link

You can find it number 16:
image

I didn't know what Tr meant in the name of the repository, Now I am guessing it refers to Turkey 😅

That means I might have made a mistake here, as that field is apparently optional in Turkey, but mandatory in KSA..

If it's possible, could you merge it nonetheless?

It will make life much easier for developer using the nuget package and targeting other countries, and it will not negatively impact Turkey targeting developers..

Thanks very much for this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants